Update billing address migration tasks with batch limit #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 18, 2021
core/lib/tasks/migrations/migrate_default_billing_addresses_to_address_book.rake
Outdated
Show resolved
Hide resolved
spaghetticode
force-pushed
the
migrate-addresses-in-batches
branch
from
034c851 to
bcaff67
Compare
When running the tasks on large DBs it makes sense to limit the number of records updated on each transaction in order to avoid locking the records (or the whole table) for too long. The default batch size is 100'000 and it can be overridden by passing a different value when invoking the tasks. For example, this will set the batch size to 1000 rows: rake solidus:migrations:migrate_default_billing_addresses_to_address_book:up[1000]
spaghetticode
force-pushed
the
migrate-addresses-in-batches
branch
from
bcaff67 to
45c364b
Compare
jarednorman
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the task on large DBs it makes sense to limit the number of records updated on each transaction in order to avoid locking the records (or the whole table) for too long.
The default batch size is 100'000 and it can be overridden by passing a different value when invoking the task. For example,
this will set the batch size to 1000 rows:
Checklist: